Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Nested error JSON #3054

Open
KitsuneRal opened this issue Mar 31, 2018 · 3 comments
Open

Nested error JSON #3054

KitsuneRal opened this issue Mar 31, 2018 · 3 comments

Comments

@KitsuneRal
Copy link
Member

The 429 error returned from /room/{id}/send/m.room.message/ is accompanied by the JSON body nested as follows: {"errcode":"M_UNKNOWN","error":"{\"errcode\":\"M_LIMIT_EXCEEDED\",\"error\":\"Too Many Requests\",\"retry_after_ms\":4079}"}. The request URL and the response to it can be seen in the Travis build of libqmatrixclient (failing for other reasons): https://travis-ci.org/QMatrixClient/libqmatrixclient/jobs/360536201#L1281. Fortunately the HTTP code is correct.

Possibly related to #2322.

@non-Jedi
Copy link

See also matrix-org/matrix-python-sdk#193. Does the JS-sdk handle this gracefully?

@ShadowJonathan
Copy link
Contributor

ShadowJonathan commented Sep 18, 2020

According to the spec, the /send/ endpoint is not ratelimited (today), is this still a problem @KitsuneRal?

@KitsuneRal
Copy link
Member Author

I believe it's still rate-limited - libQuotient CI confirms it. And I think it would be pretty much disastrous if it weren't.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants