Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Reduce task concurrency #16656

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Reduce task concurrency #16656

merged 2 commits into from
Nov 17, 2023

Conversation

erikjohnston
Copy link
Member

Most background tasks don't have any form of limiting on resource usage, so running ten of them at a time could be problematic for DB load. The deleting device messages task does have limiting, but we can make that less aggressive now that a) the queries are more efficient, and b) we are doing fewer in parallel.

@erikjohnston erikjohnston marked this pull request as ready for review November 17, 2023 10:13
@erikjohnston erikjohnston requested a review from a team as a code owner November 17, 2023 10:13
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I've said this before, but it might make sense to adapt what we do with background schema updates for background tasks in general?

@erikjohnston
Copy link
Member Author

I believe I've said this before, but it might make sense to adapt what we do with background schema updates for background tasks in general?

Indeed.

@erikjohnston erikjohnston merged commit 700c8a0 into develop Nov 17, 2023
38 checks passed
@erikjohnston erikjohnston deleted the erikj/reduce_task_concurrency branch November 17, 2023 13:14
erikjohnston added a commit that referenced this pull request Nov 17, 2023
Now that we're reducing concurrency (#16656), this is more important.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants