Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Also discard 'caches' and 'backfill' stream POSITIONS #16655

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

erikjohnston
Copy link
Member

Follow on from #16640

@erikjohnston erikjohnston marked this pull request as ready for review November 17, 2023 10:09
@erikjohnston erikjohnston requested a review from a team as a code owner November 17, 2023 10:09
synapse/replication/tcp/streams/_base.py Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we no longer need #16557 (is this a more general solution)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, that PR reduces the amount sent, this is reducing the processing of what we receive (but its still non-zero)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought #16561 reduced the amount sent? I guess #16557 does so too though.

Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this the ones that we don't apply this to are the PresenceFederationStream and TypingStream (the two direct sub-classes of Stream without the additional logic).

@clokep clokep changed the title Also discard 'caches' stream POSITIONS Also discard 'caches' and 'backfill' stream POSITIONS Nov 17, 2023
@erikjohnston erikjohnston merged commit 6fec2d0 into develop Nov 17, 2023
41 checks passed
@erikjohnston erikjohnston deleted the erikj/discard_cache_stream branch November 17, 2023 14:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants