Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Enable refreshable tokens on the admin registration endpoint #16642

Merged

Conversation

cvwright
Copy link
Contributor

@cvwright cvwright commented Nov 15, 2023

This PR adds support for refresh tokens on the admin API registration endpoint /_synapse/admin/v1/register.

See #16641 for more details.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

@cvwright cvwright requested a review from a team as a code owner November 15, 2023 20:31
@cvwright
Copy link
Contributor Author

I'm not sure what's going on with the failing tests. The sytest tests give me run-tests PASSED on my dev machine when run according to the instructions at https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#run-the-integration-tests-sytest

@clokep
Copy link
Member

clokep commented Nov 16, 2023

Reran them, the flake should be fixed now?

Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@erikjohnston erikjohnston merged commit 1a5f9bb into matrix-org:develop Nov 22, 2023
38 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants