This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
More efficiently handle no-op POSITION #16640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We may receive `POSITION` commands where we already know that worker has advanced past that position, so there is no point in handling it.
erikjohnston
force-pushed
the
erikj/discard_positions
branch
from
ad9242c
to
04f0e1d
Compare
clokep
reviewed
Nov 15, 2023
clokep
approved these changes
Nov 16, 2023
erikjohnston
added a commit
that referenced
this pull request
Nov 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may receive
POSITIONcommands where we already know that worker has advanced past that position, so there is no point in handling it.