Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Improve documentation for /_synapse/admin/v1/rooms/<room_id>/timestamp_to_event #16631

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

Half-Shot
Copy link
Collaborator

It returns an extra timestamp parameter, and also the event_id description was a little confused.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

…mp_to_event`

It returns an extra timestamp parameter, and also the event_id description was a little confused.
@Half-Shot Half-Shot requested a review from a team as a code owner November 14, 2023 16:28
@github-actions github-actions bot deployed to PR Documentation Preview November 14, 2023 16:29 Active
@github-actions github-actions bot deployed to PR Documentation Preview November 14, 2023 16:32 Active
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/admin_api/rooms.md Outdated Show resolved Hide resolved
changelog.d/16631.doc Outdated Show resolved Hide resolved
@github-actions github-actions bot deployed to PR Documentation Preview November 14, 2023 16:39 Active
@github-actions github-actions bot deployed to PR Documentation Preview November 14, 2023 16:40 Active
@clokep clokep merged commit 4dd18bd into develop Nov 14, 2023
31 checks passed
@clokep clokep deleted the hs/improve-docs-for-timestamp-to-event branch November 14, 2023 16:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants