This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Use dbname instead of database for Postgres config. #16618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though we probably would(?) want to do this in the future if we drop support for psycopg2. |
I'm expecting people to opt into psycopg(3) so they would need the appropriate configuration for that anyway. |
DMRobertson
approved these changes
Nov 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the psycopg2 docs the connection should use
dbname:I don't think we need to do mapping or anything in the config since we document this as drive-specific configuration.
This was taken from my psycopg3 branch, which requires using
dbname.