This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix a long-standing bug where Synapse would not unbind third-party identifiers for Application Service users when deactivated and would not emit a compliant response. #16617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting AS user Fixes #16608
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
clokep
approved these changes
Nov 9, 2023
| if requester.app_service: | ||
| await self._deactivate_account_handler.deactivate_account( | ||
| requester.user.to_string(), body.erase, requester | ||
| # allow ASes to deactivate their own users: |
There was a problem hiding this comment.
This somehow made me think we should be checking if the appservice owns the user, but requester.app_service wouldn't exist unless the AS owned the user.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16608
Base:
developOriginal commit schedule, with full messages:
Don't skip unbinding 3PIDs and returning success status when deactivating AS user
Fixes Deactivating an account as an application service using
user_idyields a response not containingid_server_unbind_result#16608