This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Use _invalidate_cache_and_stream_bulk in more places. #16616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
commented
Nov 9, 2023
Comment on lines
+318
to
320
| for event_id, should_delete in event_rows: | ||
| if should_delete: | ||
| self._invalidate_cache_and_stream( | ||
| txn, self.have_seen_event, (room_id, event_id) | ||
| ) | ||
| self.invalidate_get_event_cache_after_txn(txn, event_id) |
There was a problem hiding this comment.
This invalidates local caches, so I think is fine to leave in the loop.
clokep
commented
Nov 9, 2023
Comment on lines
+564
to
+569
| tokens = self.db_pool.simple_select_list_txn( | ||
| txn, | ||
| table="access_tokens", | ||
| keyvalues={"user_id": user_id}, | ||
| retcol="token", | ||
| retcols=("token",), | ||
| ) |
There was a problem hiding this comment.
Instead of unpacking a tuple from the database (using the select_onecol version) and then repacking it into a tuple, it makes more sense to simply pass the tuples in.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #16613 to use the new bulk invalidation logic in more places.
I found these via:
I'm likely missing more though. 🤷