-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
if clauses: | ||
sql = "%s WHERE %s" % (sql, " AND ".join(clauses)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's always at least 1 clause, so this is just a minor clean-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible; no objections. Not sure I understand what the difficulty is with postgres though. Shout if you want a rubber duck.
@@ -209,3 +209,63 @@ def test_delete_one(self) -> Generator["defer.Deferred[object]", object, None]: | |||
self.mock_txn.execute.assert_called_with( | |||
"DELETE FROM tablename WHERE keycol = ?", ["Go away"] | |||
) | |||
|
|||
@defer.inlineCallbacks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess twisted/trial doesn't let you write test methods using async def ...
? :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They do, but I think not on our lowest bound. I started testing it and got into some dependency hell and stopped.
@DMRobertson Thanks for the feedback, can you take another look? I've:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tolerating my pedantry :)
After being a bit nervous about #16583, I wanted to write some tests for more of the
simple_*
methods of theDatabasePool
.