This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Collect information for PushRuleEvaluator in parallel. #16590
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PushRuleEvaluator
requires a bunch of information about the room / sender, etc. based on the new event, most of this information does not depend on each other and can be calculated in parallel.Additionally
bulk_get_push_rules
has two separate queries which can be done in parallel.Ideally we would use PostgreSQL pipeling here instead, but that's not available to use in psycopg2 (or PostgreSQL < 14).
Note that these queries running in parallel will still be subject to thread pool contention, but worse case they get serialized, as they are today.