This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix HTTP repl response to use minimum token #16578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
added
the
X-Release-Blocker
|
Feels like we should have written a test for the cross-worker HTTP request case(?) |
DMRobertson
approved these changes
Oct 30, 2023
DMRobertson
reviewed
Oct 30, 2023
Comment on lines
435
to
+436
| response[_STREAM_POSITION_KEY] = { | ||
| stream.NAME: stream.current_token(self._instance_name) | ||
| stream.NAME: stream.minimal_local_current_token() |
There was a problem hiding this comment.
Can you remind me: why does the requester submit this information again? When submitted, should the requester submit the minimum or maximum current token?
There was a problem hiding this comment.
This data is used so that the other side can "wait" until all the streams have advanced to the position included, i.e. when the instance starts processing the request/response it knows that e.g. all cache invalidations have correctly happened.
The difference between request/response here is fairly immaterial.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #16473, where we tried to change the HTTP replication to return the minimum current token for a stream (as this is used to wait for a position in the stream). However, turns out we need to change this in two places, both the request and response.