Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove remaining usage of cursor_to_dict. #16564

Merged
merged 12 commits into from
Oct 31, 2023
Merged

Conversation

clokep
Copy link
Member

@clokep clokep commented Oct 27, 2023

These were all one-offs, most of them get replaced with attrs classes. It is a bit annoying to make a class used in a single spot, but at least it does improve type hints a bit.

@clokep clokep force-pushed the clokep/axe-cursor-to-dict-7 branch from bd2e9cf to 16d2e53 Compare October 27, 2023 18:39
@clokep clokep marked this pull request as ready for review October 30, 2023 13:11
@clokep clokep requested a review from a team as a code owner October 30, 2023 13:11
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments for you to mull over, but nothing blocking.

Congratulations on excising a pet peeve :)

@clokep clokep merged commit cfb6d38 into develop Oct 31, 2023
41 checks passed
@clokep clokep deleted the clokep/axe-cursor-to-dict-7 branch October 31, 2023 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants