Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

complement: enable dirty runs #16520

Merged
merged 18 commits into from
Oct 27, 2023
Merged

complement: enable dirty runs #16520

merged 18 commits into from
Oct 27, 2023

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Oct 18, 2023

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

@kegsay kegsay requested a review from a team as a code owner October 18, 2023 16:51
Dirty runs can cause many containers to be running concurrently,
which seems to easily exhaust resources on the host. The increased
speedup from dirty runs also seems to use more db connections on
workers, which are misconfigured currently to have
`SUM(workers * cp_max) > max_connections`, causing
```
FATAL:  sorry, too many clients already
```
which results in tests failing.
@clokep
Copy link
Member

clokep commented Oct 19, 2023

This had 1 flake, not sure if that's expected or not?

@kegsay
Copy link
Member Author

kegsay commented Oct 20, 2023

Unsure. The increases concurrency means we see different kinds of flakes from before. They are always the partial state join tests though, and they've passed in the past, so tempted to merge and ignore, but this isn't my project :D

@kegsay
Copy link
Member Author

kegsay commented Oct 25, 2023

The cause of the flakiness was terribly slow partial state tests, caused by the reduced connection pool limits on postgres mode. It's now only reducing the connection pool when running with workers.

@kegsay kegsay merged commit 11a8ae0 into develop Oct 27, 2023
32 of 38 checks passed
@kegsay kegsay deleted the kegan/more-dirty branch October 27, 2023 17:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants