This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Run trial/integration tests if .ci is modified. #16512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
force-pushed
the
clokep/more-ci
branch
from
e8dec5f
to
727f8e9
Compare
DMRobertson
reviewed
Oct 18, 2023
| @@ -37,15 +37,18 @@ jobs: | |||
| - 'Cargo.toml' | |||
| - 'Cargo.lock' | |||
| - '.rustfmt.toml' | |||
| - '.github/workflows/tests.yml' | |||
There was a problem hiding this comment.
At what point are we reinventing make here? (Pedantry: make wouldn't help us here because there's no "I have run tests" file whose timestamp can be used to decide what needs to be run.)
There was a problem hiding this comment.
🤷 Idk, this is always going to be a bit manual though, isn't it? (I hate CI.)
DMRobertson
approved these changes
Oct 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #16511.