Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Improve performance of delete device messages query #16492

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

MatMaul
Copy link
Contributor

@MatMaul MatMaul commented Oct 14, 2023

cf #16479.

Signed-off-by: Mathieu Velten [email protected]

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

@MatMaul
Copy link
Contributor Author

MatMaul commented Oct 14, 2023

I am getting less rows deleted with this new query (10 instead of 12), I need to check why. All is fine.
cf #16479 (comment) for more infos and PG plans for old and new queries.

@MatMaul
Copy link
Contributor Author

MatMaul commented Oct 16, 2023

I think this is fine so undrafting it, but it may be useful to check a plan on pg11 with the new query.

@MatMaul MatMaul marked this pull request as ready for review October 16, 2023 11:49
@MatMaul MatMaul requested a review from a team as a code owner October 16, 2023 11:49
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo, thanks!

@erikjohnston erikjohnston merged commit bcff01b into matrix-org:develop Oct 18, 2023
38 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants