Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Update complement.sh to match new public API shape #16466

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Oct 11, 2023

Sister PR to matrix-org/complement#666

Context: matrix-org/complement#654 (comment)

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

@kegsay kegsay added the A-Testing Issues related to testing in complement, synapse, etc label Oct 11, 2023
@kegsay kegsay requested a review from a team as a code owner October 11, 2023 14:20
@DMRobertson
Copy link
Contributor

Try adding the complement.sh script in

integration:
- 'synapse/**'
- 'rust/**'
- 'docker/**'
- 'Cargo.toml'
- 'Cargo.lock'
- 'pyproject.toml'
- 'poetry.lock'
- 'docker/**'
to make sure CI actually runs here. (C.f. #14745 and friends)

@kegsay
Copy link
Member Author

kegsay commented Oct 11, 2023

It runs now, and fails the same failing tests on develop, which means it is in fact running those MSCs.

Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM, thanks! I'll let you merge in tandem with the complement and Dendrite change.

@kegsay kegsay merged commit f710d54 into develop Oct 12, 2023
31 of 36 checks passed
@kegsay kegsay deleted the kegan/no-msc-tags branch October 12, 2023 10:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Testing Issues related to testing in complement, synapse, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants