This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Convert simple_select_list_paginate_txn to return tuples. #16433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
commented
Oct 5, 2023
| @@ -395,7 +395,7 @@ class PresenceDestinationsRow(BaseFederationRow): | |||
| @staticmethod | |||
| def from_data(data: JsonDict) -> "PresenceDestinationsRow": | |||
| return PresenceDestinationsRow( | |||
| state=UserPresenceState.from_dict(data["state"]), destinations=data["dests"] | |||
| state=UserPresenceState(**data["state"]), destinations=data["dests"] | |||
There was a problem hiding this comment.
I didn't really need to nuke this, but it seemed like a useless method?
erikjohnston
reviewed
Oct 6, 2023
erikjohnston
approved these changes
Oct 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More of my war on
cursor_to_dict. Follow-u to #16431. This targets a single "simple" method:simple_select_list_paginate_txnand its two callers.