Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Some refactors around receipts stream #16426

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Some refactors around receipts stream #16426

merged 5 commits into from
Oct 4, 2023

Conversation

erikjohnston
Copy link
Member

A couple of refactors aimed at making it easier to make receipts stream multi-writer.

Reviewable commit-by-commit.

@erikjohnston erikjohnston marked this pull request as ready for review October 4, 2023 14:09
@erikjohnston erikjohnston requested a review from a team as a code owner October 4, 2023 14:09
clokep
clokep approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't audit all callers, but assume that mypy is mostly checking the proper types for the stream key changes.

synapse/types/__init__.py Show resolved Hide resolved
@erikjohnston erikjohnston enabled auto-merge (squash) October 4, 2023 14:48
@erikjohnston erikjohnston merged commit 80ec81d into develop Oct 4, 2023
36 of 38 checks passed
@erikjohnston erikjohnston deleted the erikj/simplify_receipts branch October 4, 2023 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clokep clokep clokep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikjohnston @clokep