Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix possible AttributeError when account-api is called over unix socket #16404

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Conversation

Sir-Photch
Copy link
Contributor

@Sir-Photch Sir-Photch commented Sep 30, 2023

Fixes #16396

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off via email
  • Code style is correct
    (run the linters)

@Sir-Photch Sir-Photch requested a review from a team as a code owner September 30, 2023 01:59
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@erikjohnston
Copy link
Member

@Sir-Photch you need to sign off this PR, as per the contributing guide.

@Sir-Photch
Copy link
Contributor Author

Sir-Photch commented Oct 6, 2023

@erikjohnston I've sent you guys an email about that

@InezMc
Copy link

InezMc commented Oct 9, 2023

Private sign off has been recieved.

@Sir-Photch you need to sign off this PR, as per the contributing guide.

@erikjohnston
Copy link
Member

Thanks both!

@erikjohnston erikjohnston merged commit 32fd9bc into matrix-org:develop Oct 9, 2023
29 of 30 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calls to /_matrix/client/v3/account/whoami return 500 when called on a unix socket
3 participants