Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Complement Dockerfiles should use fully-qualified image names #15676

Closed
reivilibre opened this issue May 26, 2023 · 0 comments · Fixed by #15689
Closed

Complement Dockerfiles should use fully-qualified image names #15676

reivilibre opened this issue May 26, 2023 · 0 comments · Fixed by #15689
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact

Comments

@reivilibre
Copy link
Contributor

I have switched to podman for rootless operation, given recent security auditing stuff, and I notice that podman prompts you to choose where to get images from:

[2/3] STEP 1/1: FROM redis:6-bullseye AS redis_base
? Please select an image: 
  ▸ docker.io/library/redis:6-bullseye
    quay.io/redis:6-bullseye

It seems like we ought to just use the fully-qualified image names anyway, as far as I know that is considered good practice given that people can have different registries configured as default?
@reivilibre reivilibre added T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact labels May 26, 2023
@realtyem realtyem mentioned this issue May 30, 2023
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Docker fully qualified image names realtyem/synapse-old
1 participant
@reivilibre