-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
ModuleAPI SSO auth callbacks #15207
ModuleAPI SSO auth callbacks #15207
Conversation
Looks like this is failing lint. |
Linters are fixed. @clokep could you please take a look again? |
I kicked off the build again, this is in our review queue. 👍 |
Thank you! :) |
@anoadragon453 what do you think of On my side I think I would favor just going for a generic |
A generic |
@MatMaul @anoadragon453 |
@yasinishyn that would be nice, thank you 🙂 |
(Removing from the review queue since it sounds like changes are planned?) |
I am sorry for the late update on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a few linting errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me! Thank you
This PR implements a callaback that is executed on any SSO auth (registration and logins). This introduces an ability to add custom callbacks using ModuleAPI.
Reasoning:
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)
Signed-off-by: Andrii Yasynyshyn [email protected]