Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Synapse calls /r0 for media over federation #15196

Closed
turt2live opened this issue Mar 2, 2023 · 1 comment · Fixed by #16701
Closed

Synapse calls /r0 for media over federation #15196

turt2live opened this issue Mar 2, 2023 · 1 comment · Fixed by #16701
Labels
A-Spec-Compliance places where synapse does not conform to the spec O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@turt2live
Copy link
Member

synapse/synapse/media/media_repository.py

Line 427 in 4fc8875

("/_matrix/media/r0/download", server_name, media_id)

It should be trying the /v3 endpoint until something like MSC1902 or similar lands. Arguably there should also be a fallback mechanism to try /r0 when /v3 fails, per M_UNRECOGNIZED in the standard error codes.
@clokep
Copy link
Member

clokep commented Mar 2, 2023

This is part of #11474, which also talks about a few other spots.

@H-Shay H-Shay added A-Spec-Compliance places where synapse does not conform to the spec T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. labels Mar 6, 2023
@clokep clokep mentioned this issue Nov 28, 2023
Merged
@turt2live turt2live mentioned this issue Nov 28, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Spec-Compliance places where synapse does not conform to the spec O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Request & follow redirects for /media/v3/download matrix-org/synapse
3 participants
@clokep @turt2live @H-Shay