Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

To-device messages have an unspecified, required message_id field #14167

Closed
babolivier opened this issue Oct 13, 2022 · 1 comment
Closed

To-device messages have an unspecified, required message_id field #14167

babolivier opened this issue Oct 13, 2022 · 1 comment
Labels
A-E2EE End-to-end encryption for Matrix clients A-Spec-Compliance places where synapse does not conform to the spec O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@babolivier
Copy link
Contributor

babolivier commented Oct 13, 2022 •
edited
Loading

#9686 introduced a message_id field in to-device messages for tracing purposes, which isn't in the spec, and which Synapse sends to all to-device messages it sends. This is confusing because the name does not imply it's intended to live out of the spec.

In an even more problematic way, Synapse also mandates it for incoming to-device EDUs (ref), meaning that other server implementations have to also implement it.

Also see discussion in #matrix-spec: https://matrix.to/#/!NasysSDfxKxZBzJJoE:matrix.org/$PWq5IoB9WUfKdUiyRjTOUG5tCFNT6pBcBT8uwUcQVTg?via=matrix.org&via=libera.chat&via=element.io
@babolivier babolivier added A-Spec-Compliance places where synapse does not conform to the spec S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. O-Uncommon Most users are unlikely to come across this or unexpected workflow A-E2EE End-to-end encryption for Matrix clients labels Oct 13, 2022
@babolivier
Copy link
Contributor Author

It is actually in the spec. Ignore me.

@babolivier babolivier closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-E2EE End-to-end encryption for Matrix clients A-Spec-Compliance places where synapse does not conform to the spec O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@babolivier