Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

CI run against Twisted trunk is failing #14008

Closed
github-actions bot opened this issue Oct 3, 2022 · 1 comment · Fixed by #14012
Closed

CI run against Twisted trunk is failing #14008

github-actions bot opened this issue Oct 3, 2022 · 1 comment · Fixed by #14012
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

See https://github.com/matrix-org/synapse/actions/runs/3172535322
@DMRobertson
Copy link
Contributor 

synapse/handlers/ui_auth/checkers.py:122: error: Item "None" of "Optional[bytes]" has no attribute "decode"  [union-attr]
synapse/handlers/cas.py:133: error: Incompatible types in assignment (expression has type "Optional[bytes]", variable has type "bytes")  [assignment]

Would guess this is twisted/twisted#11688. Twisted seem to be adding a bunch of annotations at the moment.

This was referenced Oct 3, 2022
Merged
Merged
@DMRobertson DMRobertson added T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. S-Tolerable Minor significance, cosmetic issues, low or no impact to users. O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix twisted trunk mypy errors matrix-org/synapse
1 participant
@DMRobertson