Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Faster joins: prevent enabling it with workers #13527

Closed
richvdh opened this issue Aug 15, 2022 · 1 comment · Fixed by #13531
Closed

Faster joins: prevent enabling it with workers #13527

richvdh opened this issue Aug 15, 2022 · 1 comment · Fixed by #13531
Assignees
@squahtx
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Milestone
Q3 2022: Faster j...

Comments

@richvdh
Copy link
Member

richvdh commented Aug 15, 2022 •
edited
Loading

Currently if you enable faster-joins with worker processes, you're going to get horrible cache-coherency issues. We should stop people shooting themselves in the foot like this with a check on the config setting.
@richvdh richvdh added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Aug 15, 2022
@richvdh
Copy link
Member Author

richvdh commented Aug 15, 2022

(proper support for workers is #12994)

@squahtx squahtx self-assigned this Aug 15, 2022
@squahtx squahtx mentioned this issue Aug 15, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@squahtx squahtx

Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
Q3 2022: Faster joins: fix major know...
Development

Successfully merging a pull request may close this issue.

Refuse to start when faster_joins is enabled on a worker deployment matrix-org/synapse
2 participants
@richvdh @squahtx