Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

get_rooms_for_user and get_users_in_rooms caches don't have old entries pruned #13245

Closed
erikjohnston opened this issue Jul 11, 2022 · 1 comment
Closed

get_rooms_for_user and get_users_in_rooms caches don't have old entries pruned #13245

erikjohnston opened this issue Jul 11, 2022 · 1 comment
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Milestone
Server Density

Comments

@erikjohnston
Copy link
Member

This is because it would invalidate get_users_who_share_rooms_with_user cache which relies on them.

We have removed a few usages of get_users_who_share_room_with_user recently, and now it is only used by presence (and device list changes API to handle old database rows).

This causes the synchrotron memory usage to grow.
@erikjohnston erikjohnston added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Jul 11, 2022
@erikjohnston erikjohnston added this to the Server Density milestone Jul 11, 2022
@erikjohnston
Copy link
Member Author

Fixed by #13323

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
Server Density
Development

No branches or pull requests
1 participant
@erikjohnston