Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

"Re-starting finished log context" due to RetryDestinationLimiter #12797

Closed
squahtx opened this issue May 19, 2022 · 0 comments · Fixed by #12803
Closed

"Re-starting finished log context" due to RetryDestinationLimiter #12797

squahtx opened this issue May 19, 2022 · 0 comments · Fixed by #12803
Labels
S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@squahtx
Copy link
Contributor

squahtx commented May 19, 2022

RetryDestinationLimiter.__exit__ stores retry timings in a background process:

# we deliberately do this in the background.
synapse.logging.context.run_in_background(store_retry_timings)

store_retry_timings inherits the current logcontext, which likely comes from a with LogContext(): ... further up the stack.
But there's no guarantee that store_retry_timings will finish before we exit that context manager further up the stack.

@squahtx squahtx added S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant