./scripts-dev/complement.sh and GHA complement job diverged

[Bubu]

It seems like 684d19a added the msc2716 tag to the complement.sh script but it seems that was never added to the GHA workflow here: https://github.com/matrix-org/synapse/blob/develop/.github/workflows/tests.yml#L377

Consequently that (those?) tests are now failing on develop.

[clokep]

@MadLittleMods Do you know if those tests should be passing or not?

[MadLittleMods]

I think they would pass but it looks like the Complement tests are using the org.matrix.msc2716v4 room version which hasn't merged to Synapse yet (potentially merged in #11243 or #9445 or not merged at all #11243 (comment)). Feel free to remove, it's always a juggle trying to add it back when developing a new MSC though.

I don't think the tests are running in CI (GHA) because the command is separate from complement.sh though?

[clokep]

I don't think the tests are running in CI (GHA) because the command is separate from complement.sh though?

Right, but for people developing against Synapse it is frequent to manually run complement commands with this script, so it is best to keep it in a state where it is expected to pass.

[DMRobertson]

Is this fixed by #11368?

[clokep]

Is this fixed by #11368

No, I'll do a PR to fix it.