Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Deprecation notice on the spam checker doc isn't obvious enough #10333

Closed
babolivier opened this issue Jul 7, 2021 · 2 comments · Fixed by #10395
Closed

Deprecation notice on the spam checker doc isn't obvious enough #10333

babolivier opened this issue Jul 7, 2021 · 2 comments · Fixed by #10395
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@babolivier
Copy link
Contributor

babolivier commented Jul 7, 2021 •
edited
Loading

Looks like the deprecation notice on https://matrix-org.github.io/synapse/latest/spam_checker.html is easier to miss than I thought. @anoadragon453 suggested:

as far as the warning goes, I would start by putting it below "Handling spam in Synapse", then probably bumping it to a higher header number (maybe even just h1).

we can do red - none of the themes have red text as the default (yet)
@babolivier
Copy link
Contributor Author

@anoadragon453

color red looks ok

@babolivier babolivier mentioned this issue Jul 14, 2021
Merged
@erikjohnston erikjohnston added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Jul 23, 2021
@babolivier
Copy link
Contributor Author

This was fixed by #10395, not fully sure why the issue wasn't closed automatically.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make deprecation notice of the spam checker doc more obvious matrix-org/synapse
2 participants
@babolivier @erikjohnston