Remove unstable MSC2858 APIs

[callahad]

Followup to #9627 for APIs defined in matrix-org/matrix-spec-proposals#2858

We're aiming to implement this no sooner than the first release in August. By the calendar, that should be Synapse 1.38 1.40. Thus, we can implement any time after 1.37 1.39 has branched.

Blockers:

• Synapse 1.37 1.39 has been branched
• Switch to stable endpoint/fields for MSC2858 element-hq/element-ios#4362

Tasks:

• Notify client teams of impending change and get sign-off
  • Element iOS
  • Element Android
  • Element Web
• Disable experimental flag on matrix.org
• Monitor for a few days
• Remove code from develop

[richvdh]

The first release in August is going to be 1.40, for the record.

[richvdh]

MSC2858 support is gated by an experimental flag, so the first step here is probably to turn that off on matrix.org.

[callahad]

@richvdh notes that we can check if anyone is calling the _unstable endpoint.

[callahad]

@richvdh to do that, and @reivilibre to observer (welcome (back) to the team!)

[reivilibre]

I went through the haproxy logs (thanks for your help Rich!) on matrix.org and found that we have roughly between 20 and 100 hits to this unstable API per hour.

I took a sample of one hour on one haproxy and found that all 47 requests were from iPhones.

There is already an issue to switch to the stable API, which I have commented on: element-hq/element-ios#4362 .

[reivilibre]

N.B. just for the sake of it, I found element-hq/element-android#3442 — Android has already changed over

& element-hq/element-web#17521 — web too

[richvdh]

The element iOS team expect to have an update in the app store in two weeks, and recommend waiting another week after that, for 95% penetration of the new version.

So, we should be able to revisit this w/c 23rd August.

[richvdh]

We're still seeing a few hits to the old API (like, about 6 per hour) from versions of Element-iOS older than 1.5.0. I spoke to @SBiOSoftWhare and while about 94% of people on element-ios are on the latest version, we'd like that figure to be a bit higher before we turn this off. Let's revisit in another week.

[squahtx]

We checked with the Element iOS team again and they're seeing 94% adoption of 1.5.1 today, using a possibly more accurate metric(?). We'll give it another week.

[squahtx]

Today (2021-09-09), 99.8% of iOS users are on 1.5.0+ according to the Element iOS team.

Between 2021-09-01 and 2021-09-08 we've also seen a drop in the rate of requests to the deprecated endpoints, from 37/hour to 10/hour.

[squahtx]

Now waiting for #10693 to be deployed on matrix.org

[squahtx]

Live on matrix.org now.