Also purge redactions when purging events

Previously redacints where left behind leading to backfilling issues when the server stumbled across the already existing yet to be backfilled redactions. This issues has been discussed in #8707. Signed-off-by: Andreas Rammhold <[email protected]>
matrix-org · Jul 8, 2021 · ed6a712 · ed6a712
1 parent db2d5da
commit ed6a712
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/10343.bugfix b/changelog.d/10343.bugfix
@@ -1 +1 @@
-Fix duplicate key error during backfilling of redaction events that were not deleted by the history purge job. Contributed by Andreas Rammhold (@andir).
+Fix errors during backfill caused by previously purged redaction events. Contributed by Andreas Rammhold (@andir).
diff --git a/synapse/storage/databases/main/purge_events.py b/synapse/storage/databases/main/purge_events.py
@@ -215,6 +215,7 @@ def _purge_history_txn(
             "event_relations",
             "event_search",
             "rejections",
+            "redactions",
         ):
             logger.info("[purge] removing events from %s", table)
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		Fix duplicate key error during backfilling of redaction events that were not deleted by the history purge job. Contributed by Andreas Rammhold (@andir).
		Fix errors during backfill caused by previously purged redaction events. Contributed by Andreas Rammhold (@andir).