Fix #10837 by adding JSON encoding/decoding to the Module API example… (

#10845)
matrix-org · Sep 17, 2021 · 6b6bb81 · 6b6bb81
1 parent b4c1af8
commit 6b6bb81
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/changelog.d/10845.doc b/changelog.d/10845.doc
@@ -0,0 +1 @@
+Fix some crashes in the Module API example code, by adding JSON encoding/decoding.
diff --git a/docs/modules/spam_checker_callbacks.md b/docs/modules/spam_checker_callbacks.md
@@ -136,9 +136,9 @@ class IsUserEvilResource(Resource):
         self.evil_users = config.get("evil_users") or []
 
     def render_GET(self, request: Request):
-        user = request.args.get(b"user")[0]
+        user = request.args.get(b"user")[0].decode()
         request.setHeader(b"Content-Type", b"application/json")
-        return json.dumps({"evil": user in self.evil_users})
+        return json.dumps({"evil": user in self.evil_users}).encode()
 
 
 class ListSpamChecker:
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix some crashes in the Module API example code, by adding JSON encoding/decoding.