todos

Author: MadLittleMods

synapse/federation/transport/server/_base.py

@@ -357,6 +357,7 @@ async def new_func(
 
             remote_parent_span_cm = use_span(remote_parent_span, end_on_exit=True)
 
+            # TODO: Make sure this works (traces as expected)
             with remote_parent_span_cm, local_parent_span_cm:
                 if origin and self.RATELIMIT:
                     with ratelimiter.ratelimit(origin) as d:

synapse/logging/tracing.py

@@ -529,6 +529,11 @@ def start_active_span(
     if opentelemetry is None:
         return contextlib.nullcontext()  # type: ignore[unreachable]
 
+    # TODO: Why is this necessary to satisfy this error? It has a default?
+    #  ` error: Argument "kind" to "start_span" of "Tracer" has incompatible type "Optional[SpanKind]"; expected "SpanKind"  [arg-type]`
+    if kind is None:
+        kind = SpanKind.INTERNAL
+
     span = start_span(
         name=name,
         context=context,