Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apple-touch-icons #2511

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add apple-touch-icons #2511

wants to merge 1 commit into from

Conversation

MTRNord
Copy link
Collaborator

@MTRNord MTRNord commented Sep 26, 2024

Fixes #2482

This is not tested as I dont own a device for testing this. This followed apples guidelines hence the weird sizes 🤷

Copy link

Deploying matrix-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: ae7cea7
Status: ✅  Deploy successful!
Preview URL: https://6c9a1712.matrix-website.pages.dev
Branch Preview URL: https://mtrnord-apple-touch-icon.matrix-website.pages.dev

View logs

@thibaultamartin
Copy link
Contributor

We tested on an actual device, it needs some padding

Copy link
Contributor

@thibaultamartin thibaultamartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need the extra padding after testing on-device

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apple-touch-icon is missing from markup
2 participants