update DCO, no legal name needed #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, added a news fragment for the changelog but on review of the types of entries I'm not sure it's necessary. I'll defer to y'all on that :) |
tulir
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
1886.clarification should probably be deleted to avoid confusion in the changelog
There was a problem hiding this comment.
Thank you! I've just pushed a commit with that file removed from the PR.
There was a problem hiding this comment.
(preferably both have the same text rather than deleting changelog entries - they'll coalesce at release time)
There was a problem hiding this comment.
Ahhh, gotcha. I've rebased my PR to get rid of the commit that removed that file.
bluesomewhere
force-pushed
the
update-dco
branch
from
3cd4e8a to
7784c78
Compare
turt2live
approved these changes
Jul 25, 2024
44 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing "legally identifiable" name requirement from the DCO, and also the private sign-off option as that's no longer necessary.
Opening PR to get a # to use in the changelog entry which I'll add in the next commit.
Pull Request Checklist
Signed-off-by: Josh Simmons [email protected]
Preview: https://pr1914--matrix-spec-previews.netlify.app