Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servers don't enforce PDU format #1904

Open
Kladki opened this issue Jul 7, 2024 · 2 comments
Open

Servers don't enforce PDU format #1904

Kladki opened this issue Jul 7, 2024 · 2 comments

Comments

@Kladki
Copy link
Contributor

Kladki commented Jul 7, 2024

In the room version specification, it states the format for PDUs. However, all the requirements are not fully enforced.
For example, you can send an m.room.canonical_alias event with content of null to a room, and despite that content must be an object in room version 10, Synapse, Dendrite, and Conduit allow for that event to be appended to the timeline, one way or another.

I have not tested whether all of requirements are enforced, but I would assume there is no explicit validation of the PDU format, with the only checks being side effects of things like authorization checks being performed.

@richvdh
Copy link
Member

richvdh commented Jul 8, 2024

In the room version specification, it states the format for PDUs. However, all the requirements are not fully enforced.

That sounds more like an implementation issue than a spec issue?

@Kladki
Copy link
Contributor Author

Kladki commented Jul 8, 2024

I think it is similar to #1506 in the sense that while it is an implementation issue, the fact that no known implementation actually enforced this would make this be de-facto behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants