Use tag name as the OpenAPI definition version #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Yes, that's right. It's actually a manual job to download the artifact from Github and upload it to the web server. Releases don't happen often enough for us to have automated it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to fix the spec version displayed in the Matrix API Viewer, which is set to "unstable" although I'm pretty sure it is only deployed for releases.
However I'm not sure how the OpenAPI definitions are deployed. My guess is that they use the artifact from the job triggered by tagging the release so this changes the CI script to use the tag name as the version, when it is available.
It might not fix what I want but at least it's not wrong 🙂.
Preview: https://pr1561--matrix-spec-previews.netlify.app