Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appservice API /_matrix/app/v1/transactions/ should specify maximum transaction sizes #1469

Open
Half-Shot opened this issue Mar 21, 2023 · 0 comments · May be fixed by matrix-org/matrix-spec-proposals#3982
Labels
A-Application-Services Issues affecting the AS API wart A point where the protocol is inconsistent or inelegant

Comments

@Half-Shot
Copy link
Contributor

This means we should specify a maximum limit on the number of events sent. Unstable MSCs for Appservices such as:

Will need to also specify their maximum sizes. This is needed because most HTTP listeners will specify a maximum body size for incoming requests, and in practice this is often exceeded when the AS receives a lot of traffic at once. For example, Nginx defaults to 1MB and while we shouldn't arbitrarily restrict the spec to what nginx supports, it's clear that an unlimited number of events will cause great pain.

@turt2live turt2live added A-Application-Services Issues affecting the AS API wart A point where the protocol is inconsistent or inelegant labels Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Application-Services Issues affecting the AS API wart A point where the protocol is inconsistent or inelegant
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants