-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct a small typo in the push rules spec #1465
Conversation
This example does not talk about a 'membership' field in any case. It looks like this was instead supposed to be 'topic', as the previous paragraph also talks about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I noticed in this #1464 and failed to update it. 😢
Your PR made me notice it, so in the end it still helped fixed it ✨ I'm going to take Patrick's review as an approval of this typo fix. |
(ftr, force-merge bypassed the changelog check: |
@turt2live I didn't perform a force merge, and the CI passed: https://github.com/matrix-org/matrix-spec/actions/runs/4417512313/jobs/7743320855#step:3:7 Though it looks like the CI only checks that the changelog file is in a valid directory, and has the right number. It does not check that it has a valid extension: https://github.com/matrix-org/matrix-spec/blob/db0fd307447edeb5724c9897e07e6c56d87123f6/scripts/check-newsfragments |
I swear yesterday it was saying the ci partially passed :( Sorry, and good spot: we should fix that workflow. |
This PR fixes a field name in an example that does not make sense.
The example does not talk about a "membership" field in any case. It looks like this was instead supposed to be "topic", as the previous paragraph also talks about.
Preview: https://pr1465--matrix-spec-previews.netlify.app