Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'Content' section of m.receipt is empty #1343

Closed
anoadragon453 opened this issue Nov 15, 2022 · 5 comments · Fixed by #1637
Closed

The 'Content' section of m.receipt is empty #1343

anoadragon453 opened this issue Nov 15, 2022 · 5 comments · Fixed by #1637
Labels
spec-bug Something which is in the spec, but is wrong

Comments

@anoadragon453
Copy link
Member

Link to problem area: https://spec.matrix.org/v1.4/client-server-api/#mreceipt

Issue
The "Content" section of m.receipt should feature table(s) describing the fields and types that an m.receipt can be populated with. Instead, it is just a blank space.

Expected behaviour
A rendered set of tables representing the m.receipt schema should be visible.

@anoadragon453 anoadragon453 added the spec-bug Something which is in the spec, but is wrong label Nov 15, 2022
@anoadragon453
Copy link
Member Author

anoadragon453 commented Nov 15, 2022

This might be due to the use of patternProperties?

m.ignored_user_list.yaml uses the same:

and no "Ignored User" table appears in the spec: https://spec.matrix.org/v1.4/client-server-api/#mignored_user_list

It also appears that patternProperties doesn't exist in OpenAPI 2.0, and was only added in OAI/OpenAPI-Specification#687, so arguably we shouldn't even be using it until we support OpenAPI 3.1 (see #1310 for upgrading to OpenAPI 3.1. Doing so does not magically fix this issue however). That is not how this works.

@turt2live
Copy link
Member

I'm pretty sure this is a duplicate of the issue I can't find where we discovered that additionalProperties wasn't properly rendered. Whether the field is supported by OpenAPI or not is irrelevant - we define the templates for how these things get rendered.

@anoadragon453
Copy link
Member Author

@turt2live

I'm pretty sure this is a duplicate of the issue I can't find where we discovered that additionalProperties wasn't properly rendered.

Do you mean patternProperties? Indeed, I see no mention of the text patternProperties outside of these two OpenAPI definition files, so we presumably have no handling of them in our rendering code.

@turt2live
Copy link
Member

I mean additionalProperties - I think we fixed it somewhat recently. patternProperties, for all intents and purposes, is effectively the same.

@deepbluev7
Copy link
Contributor

This seems to be a regression from r0.6.1 to v1.1 of the client spec: https://matrix.org/docs/spec/client_server/r0.6.1#m-receipt vs https://spec.matrix.org/v1.1/client-server-api/#events-5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-bug Something which is in the spec, but is wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants