keys.yml: fix one_time_keys object contents #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The alternatives previously listed under two additionalProperties levels are actually one _more_ level deeper; we still can't define them in a formal way before moving to OpenAPI 3 but at least let's be honest and say there's always a dict where there's always a dict. Also, since the same data structure is used in three places now, at least give it a name, and document the actual definition (once) separately (not using it now because it's OpenAPI 3).
turt2live
approved these changes
Jun 15, 2022
66 tasks
zecakeh
added a commit
to zecakeh/matrix-spec
that referenced
this pull request
Apr 24, 2024
This was commented prior to the port to OpenAPI 3.1 for technical reasons (matrix-org#1127). Now we can use it just fine. Signed-off-by: Kévin Commaille <[email protected]>
zecakeh
added a commit
to zecakeh/matrix-spec
that referenced
this pull request
Apr 24, 2024
This was commented prior to the port to OpenAPI 3.1 for technical reasons (matrix-org#1127). Now we can use it just fine. Signed-off-by: Kévin Commaille <[email protected]>
Merged
richvdh
pushed a commit
that referenced
this pull request
Apr 30, 2024
This was commented prior to the port to OpenAPI 3.1 for technical reasons (#1127). Now we can use it just fine. Signed-off-by: Kévin Commaille <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alternatives previously listed under two additionalProperties levels
are actually one more level deeper; we still can't define them in
a formal way before moving to OpenAPI 3 but at least let's be honest
and say there's always a dict where there's always a dict. Also,
since the same data structure is used in three places now, at least
give it a name, and document the actual definition (once) separately
(not using it now because it's OpenAPI 3).
Signed-off-by: Alexey Rusakov <[email protected]>
Preview: https://pr1127--matrix-spec-previews.netlify.app