fix: spaces hierarchy paramater types #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed `limit` parameter type to integer - changed `query` parameter type to integer A floating number does not make any sense here. Also, at least Synapse does not allow floating point numbers in here. Signed-off-by: TheOneWithTheBraid <[email protected]>
TheOneWithTheBraid
force-pushed
the
braid/spaces-typing
branch
from
11c207f
to
9d07c9a
Compare
KitsuneRal
approved these changes
May 30, 2022
turt2live
reviewed
May 31, 2022
66 tasks
td-famedly
pushed a commit
to famedly/dart_matrix_api_lite
that referenced
this pull request
Mar 22, 2024
BREAKING CHANGE (because from is now optional, so it can't be specified conditionally) See also: - matrix-org/matrix-spec#1110 - matrix-org/matrix-spec#1097
td-famedly
pushed a commit
to famedly/dart_matrix_api_lite
that referenced
this pull request
Mar 22, 2024
BREAKING CHANGE (because from is now optional, so it can't be specified conditionally) See also: - matrix-org/matrix-spec#1110 - matrix-org/matrix-spec#1097
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
limitparameter type to integerqueryparameter type to integerA floating number does not make any sense here. Also, at least Synapse
does not allow floating point numbers in here.
Signed-off-by: TheOneWithTheBraid [email protected]
Preview: https://pr1097--matrix-spec-previews.netlify.app