Fix membership state table and diagram #3730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were 2 missing cases which are legal: * `invite->knock` (a fairly silly thing to do, but legal under the auth rules) * `external->leave (via /kick)` (another somewhat silly thing to do, but no different than `external->ban (via /ban)`) The state table considered the first as illegal, which is untrue.
4 tasks
Co-authored-by: Richard van der Hoff <[email protected]>
This was referenced May 27, 2022
RiotTranslateBot
pushed a commit
to RiotTranslateBot/matrix-doc
that referenced
this pull request
Aug 22, 2023
* Fix membership state table and diagram There were 2 missing cases which are legal: * `invite->knock` (a fairly silly thing to do, but legal under the auth rules) * `external->leave (via /kick)` (another somewhat silly thing to do, but no different than `external->ban (via /ban)`) The state table considered the first as illegal, which is untrue. * Changelog * Make the graph prettier * Update changelogs/client_server/newsfragments/3730.clarification Co-authored-by: Richard van der Hoff <[email protected]> Co-authored-by: Richard van der Hoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 2 missing cases which are legal under the auth rules:
invite->knock(a fairly silly thing to do, but legal)external->leave (via /kick)(another somewhat silly thing to do, but no different thanexternal->ban (via /ban))The state table considered the first as illegal, which is untrue.
Preview: https://pr3730--matrix-org-previews.netlify.app