Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeline: aggregated events aren't well ordered #4161

Open
bnjbvr opened this issue Oct 22, 2024 · 0 comments
Open

timeline: aggregated events aren't well ordered #4161

bnjbvr opened this issue Oct 22, 2024 · 0 comments
Labels
A-Timeline bug Something isn't working

Comments

@bnjbvr
Copy link
Member

bnjbvr commented Oct 22, 2024

Aggregation events (edits, reactions) aren't well ordered in the timeline: we don't really know how to order them relative to each other. In the general case, it won't be a problem, but it might lead to discrepancies in a few cases:

  • when we have a bundled edit, for instance, right now we'll always prefer it to a pending edit. This might be wrong if the pending edit is more up-to-date than the bundled edit (i.e. the related pending edit is after the bundled edit event, in the overall ordering).
  • when we already have a pending edit and another comes in, we do some best-effort guessing if the new pending edit overrides the previous one or would be overridden by the previous one.

Ideally, the protocol would give us some perfect ordering over events, so we don't have to do any kind of guessing / rejiggering ourselves, e.g. with something akin to MSC4033. Otherwise, we may be able to use the all_events internal ordering (or the ordering provided by the Event cache, in some future).

@bnjbvr bnjbvr added bug Something isn't working A-Timeline labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant