Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the session ID in m.room_key.withheld #3524

Closed
kegsay opened this issue Jun 7, 2024 · 0 comments · Fixed by #3591
Closed

Log the session ID in m.room_key.withheld #3524

kegsay opened this issue Jun 7, 2024 · 0 comments · Fixed by #3591
Assignees

Comments

@kegsay
Copy link
Member

kegsay commented Jun 7, 2024

It makes debugging easier. Currently they get logged like this:

2024-06-05T16:17:36.266466Z DEBUG matrix_sdk_crypto::machine: Received a to-device event | crates/matrix-sdk-crypto/src/machine.rs:1191 | spans: root > next_sync_with_lock{store_generation=8226 store_generation=8226} > sync_once{pos="2" pos="2"} > handle_response > preprocess_to_device_events > receive_sync_changes > receive_to_device_event{sender="@xxx:element.io" sender="@xxx:element.io" event_type="m.room_key.withheld" event_type="m.room_key.withheld" message_id="e380dcf0-571d-4271-818e-e556bb041f4d" message_id="e380dcf0-571d-4271-818e-e556bb041f4d"}

This isn't enough to tie it to the session ID without also having the sender rageshake (as that includes the message_id).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants