Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recovery: event handlers ran a request in the same task, slowing down the task's progress #3162

Open
bnjbvr opened this issue Feb 23, 2024 · 0 comments

Comments

@bnjbvr
Copy link
Member

bnjbvr commented Feb 23, 2024

In these two event handlers added automatically when enabling key recovery, we start a network request to get the latest version of the state event. This slows down progress on the sync task, which can be an issue if the server is also busy doing other things, or very slow to respond.

Possible fixes:

  • run the request in a background task (make sure there's only one, if there's one active consider cancelling it and restarting it, etc.)
  • get the event from the store; apparently not the best, because the sliding sync proxy can return stale state account data events.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant