From 173aeb519975b42b6491d7b9d0fbd1ec6aec77f1 Mon Sep 17 00:00:00 2001 From: Andy Balaam Date: Tue, 1 Feb 2022 13:36:20 +0000 Subject: [PATCH 01/12] Render a CollapsibleButton's children (needed by UploadButton) --- src/components/views/rooms/CollapsibleButton.tsx | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/components/views/rooms/CollapsibleButton.tsx b/src/components/views/rooms/CollapsibleButton.tsx index a0a802d6b4b..c08073d8e25 100644 --- a/src/components/views/rooms/CollapsibleButton.tsx +++ b/src/components/views/rooms/CollapsibleButton.tsx @@ -25,7 +25,7 @@ interface ICollapsibleButtonProps extends ComponentProps { title: string; } -export const CollapsibleButton = ({ title, className, ...props }: ICollapsibleButtonProps) => { +export const CollapsibleButton = ({ title, children, className, ...props }: ICollapsibleButtonProps) => { const inOverflowMenu = !!useContext(OverflowMenuContext); if (inOverflowMenu) { return { title } + { children } ; + } else { + return + { children } + ; } - - return ; }; export default CollapsibleButton; From e8014b19ea37a6c33bf7311a44d51d229ed61cba Mon Sep 17 00:00:00 2001 From: Andy Balaam Date: Tue, 1 Feb 2022 13:37:43 +0000 Subject: [PATCH 02/12] Make UploadButton ready to live inside an overflow menu --- src/components/views/rooms/MessageComposerButtons.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/components/views/rooms/MessageComposerButtons.tsx b/src/components/views/rooms/MessageComposerButtons.tsx index a5ebddde890..cfe88f685f9 100644 --- a/src/components/views/rooms/MessageComposerButtons.tsx +++ b/src/components/views/rooms/MessageComposerButtons.tsx @@ -219,7 +219,7 @@ class UploadButton extends React.Component { dis.dispatch({ action: 'require_registration' }); return; } - this.uploadInput.current.click(); + this.uploadInput.current?.click(); }; private onUploadFileInputChange = (ev: React.ChangeEvent) => { @@ -250,7 +250,7 @@ class UploadButton extends React.Component { render() { const uploadInputStyle = { display: 'none' }; return ( - { multiple onChange={this.onUploadFileInputChange} /> - + ); } } From 5e955dfa170218652977694b51197ff6e435cfcf Mon Sep 17 00:00:00 2001 From: Andy Balaam Date: Tue, 1 Feb 2022 13:39:21 +0000 Subject: [PATCH 03/12] Always show overflow menu in composer: main buttons are emoji and attach --- .../views/rooms/MessageComposerButtons.tsx | 83 ++++++++----------- .../rooms/MessageComposerButtons-test.tsx | 39 +++++++-- 2 files changed, 67 insertions(+), 55 deletions(-) diff --git a/src/components/views/rooms/MessageComposerButtons.tsx b/src/components/views/rooms/MessageComposerButtons.tsx index cfe88f685f9..799d9de9660 100644 --- a/src/components/views/rooms/MessageComposerButtons.tsx +++ b/src/components/views/rooms/MessageComposerButtons.tsx @@ -59,53 +59,47 @@ const MessageComposerButtons: React.FC = (props: IProps) => { const matrixClient: MatrixClient = useContext(MatrixClientContext); const { room, roomId } = useContext(RoomContext); - return ( - props.haveRecording - ? null - : props.narrowMode - ? narrowMode(props, room, roomId, matrixClient) - : wideMode(props, room, roomId, matrixClient) - ); -}; + if (props.haveRecording) { + return null; + } -function wideMode( - props: IProps, - room: Room, - roomId: string, - matrixClient: MatrixClient, -): ReactElement { - return <> - { pollButton(props, room) } - { uploadButton(props, roomId) } - { showLocationButton(props, room, roomId, matrixClient) } - { emojiButton(props) } - { showStickersButton(props) } - { voiceRecordingButton(props) } - ; -} + let mainButtons: ReactElement[]; + let moreButtons: ReactElement[]; + if (props.narrowMode) { + mainButtons = [ + emojiButton(props), + ]; + moreButtons = [ + uploadButton(props, roomId), + pollButton(room), + showLocationButton(props, room, roomId, matrixClient), + showStickersButton(props), + voiceRecordingButton(props), + ]; + } else { + mainButtons = [ + emojiButton(props), + uploadButton(props, roomId), + ]; + moreButtons = [ + pollButton(room), + showLocationButton(props, room, roomId, matrixClient), + showStickersButton(props), + voiceRecordingButton(props), + ]; + } + + mainButtons = mainButtons.filter((x: ReactElement) => x); + moreButtons = moreButtons.filter((x: ReactElement) => x); -function narrowMode( - props: IProps, - room: Room, - roomId: string, - matrixClient: MatrixClient, -): ReactElement { const moreOptionsClasses = classNames({ mx_MessageComposer_button: true, mx_MessageComposer_buttonMenu: true, mx_MessageComposer_closeButtonMenu: props.isMenuOpen, }); - const moreButtons = [ - pollButton(props, room), - showLocationButton(props, room, roomId, matrixClient), - emojiButton(props), - showStickersButton(props), - voiceRecordingButton(props), - ].filter(x => x); - return <> - { uploadButton(props, roomId) } + { mainButtons } ) } ; -} +}; function emojiButton(props: IProps): ReactElement { return props.setStickerPickerOpen(!props.isStickerPickerOpen)} - title={ - props.narrowMode - ? _t("Send a sticker") - : props.isStickerPickerOpen - ? _t("Hide Stickers") - : _t("Show Stickers") - } + title={_t("Send a sticker")} /> : null ); @@ -301,7 +289,7 @@ function voiceRecordingButton(props: IProps): ReactElement { ); } -function pollButton(props: IProps, room: Room): ReactElement { +function pollButton(room: Room): ReactElement { return ; } @@ -311,6 +299,7 @@ interface IPollButtonProps { class PollButton extends React.PureComponent { static contextType = OverflowMenuContext; + public context!: React.ContextType; private onCreateClick = () => { this.context?.(); // close overflow menu diff --git a/test/components/views/rooms/MessageComposerButtons-test.tsx b/test/components/views/rooms/MessageComposerButtons-test.tsx index 1fc93238488..d9e7e6b9bbf 100644 --- a/test/components/views/rooms/MessageComposerButtons-test.tsx +++ b/test/components/views/rooms/MessageComposerButtons-test.tsx @@ -34,23 +34,45 @@ const MessageComposerButtons = TestUtils.wrapInMatrixClientContext( ); describe("MessageComposerButtons", () => { - it("Renders all buttons in wide mode", () => { + it("Renders emoji and upload buttons in wide mode", () => { const buttons = wrapAndRender( {}} />, ); expect(buttonLabels(buttons)).toEqual([ - "Create poll", + "Add emoji", "Upload file", - "Share location", + "More options", + ]); + }); + + it("Renders other buttons in menu in wide mode", () => { + const buttons = wrapAndRender( + {}} + />, + ); + + expect(buttonLabels(buttons)).toEqual([ "Add emoji", - "Show Stickers", - "Send voice message", + "Upload file", + "More options", + [ + "Create poll", + "Share location", + "Send a sticker", + "Send voice message", + ], ]); }); @@ -61,11 +83,12 @@ describe("MessageComposerButtons", () => { narrowMode={true} showLocationButton={true} showStickersButton={true} + toggleButtonMenu={() => {}} />, ); expect(buttonLabels(buttons)).toEqual([ - "Upload file", + "Add emoji", "More options", ]); }); @@ -82,12 +105,12 @@ describe("MessageComposerButtons", () => { ); expect(buttonLabels(buttons)).toEqual([ - "Upload file", + "Add emoji", "More options", [ + "Upload file", "Create poll", "Share location", - "Add emoji", "Send a sticker", ], ]); From bf78ea55dfab92c1ec5b7e6c864f81a4a4f9bc5d Mon Sep 17 00:00:00 2001 From: Andy Balaam Date: Mon, 31 Jan 2022 11:57:29 +0000 Subject: [PATCH 04/12] Re-order composer buttons as per design --- src/components/views/rooms/MessageComposerButtons.tsx | 8 ++++---- .../views/rooms/MessageComposerButtons-test.tsx | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/components/views/rooms/MessageComposerButtons.tsx b/src/components/views/rooms/MessageComposerButtons.tsx index 799d9de9660..7e5cfa21033 100644 --- a/src/components/views/rooms/MessageComposerButtons.tsx +++ b/src/components/views/rooms/MessageComposerButtons.tsx @@ -71,10 +71,10 @@ const MessageComposerButtons: React.FC = (props: IProps) => { ]; moreButtons = [ uploadButton(props, roomId), - pollButton(room), - showLocationButton(props, room, roomId, matrixClient), showStickersButton(props), voiceRecordingButton(props), + pollButton(room), + showLocationButton(props, room, roomId, matrixClient), ]; } else { mainButtons = [ @@ -82,10 +82,10 @@ const MessageComposerButtons: React.FC = (props: IProps) => { uploadButton(props, roomId), ]; moreButtons = [ - pollButton(room), - showLocationButton(props, room, roomId, matrixClient), showStickersButton(props), voiceRecordingButton(props), + pollButton(room), + showLocationButton(props, room, roomId, matrixClient), ]; } diff --git a/test/components/views/rooms/MessageComposerButtons-test.tsx b/test/components/views/rooms/MessageComposerButtons-test.tsx index d9e7e6b9bbf..1c8ad4dcf73 100644 --- a/test/components/views/rooms/MessageComposerButtons-test.tsx +++ b/test/components/views/rooms/MessageComposerButtons-test.tsx @@ -68,10 +68,10 @@ describe("MessageComposerButtons", () => { "Upload file", "More options", [ - "Create poll", - "Share location", "Send a sticker", "Send voice message", + "Create poll", + "Share location", ], ]); }); @@ -109,9 +109,9 @@ describe("MessageComposerButtons", () => { "More options", [ "Upload file", + "Send a sticker", "Create poll", "Share location", - "Send a sticker", ], ]); }); From 3de340550792add5e917b73a7a68d400bc702e17 Mon Sep 17 00:00:00 2001 From: Andy Balaam Date: Mon, 31 Jan 2022 12:41:33 +0000 Subject: [PATCH 05/12] Re-word composer button captions to be simple nouns --- .../views/location/LocationButton.tsx | 4 +-- .../views/rooms/MessageComposerButtons.tsx | 10 +++---- src/i18n/strings/en_EN.json | 17 ++++++----- .../rooms/MessageComposerButtons-test.tsx | 28 +++++++++---------- 4 files changed, 28 insertions(+), 31 deletions(-) diff --git a/src/components/views/location/LocationButton.tsx b/src/components/views/location/LocationButton.tsx index 815e001717d..d3f6e7cb3d0 100644 --- a/src/components/views/location/LocationButton.tsx +++ b/src/components/views/location/LocationButton.tsx @@ -72,13 +72,11 @@ export const LocationButton: React.FC = ({ roomId, sender, menuPosition }, ); - // TODO: replace ContextMenuTooltipButton with a unified representation of - // the header buttons and the right panel buttons return { contextMenu } diff --git a/src/components/views/rooms/MessageComposerButtons.tsx b/src/components/views/rooms/MessageComposerButtons.tsx index 7e5cfa21033..877c70cca54 100644 --- a/src/components/views/rooms/MessageComposerButtons.tsx +++ b/src/components/views/rooms/MessageComposerButtons.tsx @@ -168,7 +168,7 @@ const EmojiButton: React.FC = ({ addEmoji, menuPosition }) => { contextMenu } @@ -247,7 +247,7 @@ class UploadButton extends React.Component { props.setStickerPickerOpen(!props.isStickerPickerOpen)} - title={_t("Send a sticker")} + title={props.isStickerPickerOpen ? _t("Hide stickers") : _t("Sticker")} /> : null ); @@ -284,7 +284,7 @@ function voiceRecordingButton(props: IProps): ReactElement { key="voice_message_send" className="mx_MessageComposer_button mx_MessageComposer_voiceMessage" onClick={props.onRecordStartEndClick} - title={_t("Send voice message")} + title={_t("Voice Message")} /> ); } @@ -339,7 +339,7 @@ class PollButton extends React.PureComponent { ); } diff --git a/src/i18n/strings/en_EN.json b/src/i18n/strings/en_EN.json index bff54532f9d..847620d6a06 100644 --- a/src/i18n/strings/en_EN.json +++ b/src/i18n/strings/en_EN.json @@ -1694,13 +1694,12 @@ "You do not have permission to post to this room": "You do not have permission to post to this room", "%(seconds)ss left": "%(seconds)ss left", "Send voice message": "Send voice message", - "Add emoji": "Add emoji", - "Upload file": "Upload file", - "Send a sticker": "Send a sticker", - "Hide Stickers": "Hide Stickers", - "Show Stickers": "Show Stickers", + "Emoji": "Emoji", + "Hide stickers": "Hide stickers", + "Sticker": "Sticker", + "Voice Message": "Voice Message", "You do not have permission to start polls in this room.": "You do not have permission to start polls in this room.", - "Create poll": "Create poll", + "Poll": "Poll", "Bold": "Bold", "Italics": "Italics", "Strikethrough": "Strikethrough", @@ -2095,7 +2094,6 @@ "Invalid file%(extra)s": "Invalid file%(extra)s", "Error decrypting image": "Error decrypting image", "Show image": "Show image", - "Sticker": "Sticker", "Image": "Image", "Join the conference at the top of this room": "Join the conference at the top of this room", "Join the conference from the room information card on the right": "Join the conference from the room information card on the right", @@ -2153,10 +2151,11 @@ "Submit logs": "Submit logs", "Can't load this message": "Can't load this message", "toggle event": "toggle event", - "Share location": "Share location", + "Location": "Location", "We couldn’t send your location": "We couldn’t send your location", "Element could not send your location. Please try again later.": "Element could not send your location. Please try again later.", "Could not fetch location": "Could not fetch location", + "Share location": "Share location", "Element was denied permission to fetch your location. Please allow location access in your browser settings.": "Element was denied permission to fetch your location. Please allow location access in your browser settings.", "Failed to fetch your location. Please try again later.": "Failed to fetch your location. Please try again later.", "Timed out trying to fetch your location. Please try again later.": "Timed out trying to fetch your location. Please try again later.", @@ -2295,6 +2294,7 @@ "%(oneUser)schanged the server ACLs %(count)s times|one": "%(oneUser)schanged the server ACLs", "%(severalUsers)schanged the pinned messages for the room %(count)s times.|other": "%(severalUsers)schanged the pinned messages for the room %(count)s times.", "%(oneUser)schanged the pinned messages for the room %(count)s times.|other": "%(oneUser)schanged the pinned messages for the room %(count)s times.", + "Create poll": "Create poll", "Create Poll": "Create Poll", "Failed to post poll": "Failed to post poll", "Sorry, the poll you tried to create was not posted.": "Sorry, the poll you tried to create was not posted.", @@ -3276,7 +3276,6 @@ "Commands": "Commands", "Command Autocomplete": "Command Autocomplete", "Community Autocomplete": "Community Autocomplete", - "Emoji": "Emoji", "Emoji Autocomplete": "Emoji Autocomplete", "Notify the whole room": "Notify the whole room", "Room Notification": "Room Notification", diff --git a/test/components/views/rooms/MessageComposerButtons-test.tsx b/test/components/views/rooms/MessageComposerButtons-test.tsx index 1c8ad4dcf73..78bf64496ed 100644 --- a/test/components/views/rooms/MessageComposerButtons-test.tsx +++ b/test/components/views/rooms/MessageComposerButtons-test.tsx @@ -46,8 +46,8 @@ describe("MessageComposerButtons", () => { ); expect(buttonLabels(buttons)).toEqual([ - "Add emoji", - "Upload file", + "Emoji", + "Attachment", "More options", ]); }); @@ -64,14 +64,14 @@ describe("MessageComposerButtons", () => { ); expect(buttonLabels(buttons)).toEqual([ - "Add emoji", - "Upload file", + "Emoji", + "Attachment", "More options", [ - "Send a sticker", - "Send voice message", - "Create poll", - "Share location", + "Sticker", + "Voice Message", + "Poll", + "Location", ], ]); }); @@ -88,7 +88,7 @@ describe("MessageComposerButtons", () => { ); expect(buttonLabels(buttons)).toEqual([ - "Add emoji", + "Emoji", "More options", ]); }); @@ -105,13 +105,13 @@ describe("MessageComposerButtons", () => { ); expect(buttonLabels(buttons)).toEqual([ - "Add emoji", + "Emoji", "More options", [ - "Upload file", - "Send a sticker", - "Create poll", - "Share location", + "Attachment", + "Sticker", + "Poll", + "Location", ], ]); }); From df7880c6f53174926f2ae095a4b2f8fb9943e349 Mon Sep 17 00:00:00 2001 From: Andy Balaam Date: Mon, 31 Jan 2022 12:47:22 +0000 Subject: [PATCH 06/12] Don't rotate More options button when clicked --- res/css/views/rooms/_MessageComposer.scss | 5 ----- 1 file changed, 5 deletions(-) diff --git a/res/css/views/rooms/_MessageComposer.scss b/res/css/views/rooms/_MessageComposer.scss index c55e803747e..cba0a1e70da 100644 --- a/res/css/views/rooms/_MessageComposer.scss +++ b/res/css/views/rooms/_MessageComposer.scss @@ -271,11 +271,6 @@ limitations under the License. mask-image: url('$(res)/img/image-view/more.svg'); } -.mx_MessageComposer_closeButtonMenu::before { - transform: rotate(90deg); - transform-origin: center; -} - .mx_MessageComposer_sendMessage { cursor: pointer; position: relative; From 763b908f49158aac1ac98130703c7b89720a3844 Mon Sep 17 00:00:00 2001 From: Andy Balaam Date: Tue, 1 Feb 2022 14:50:21 +0000 Subject: [PATCH 07/12] Move the composer menu and dialogs 16px in from right --- res/css/structures/_ContextualMenu.scss | 2 +- res/css/views/rooms/_MessageComposer.scss | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/res/css/structures/_ContextualMenu.scss b/res/css/structures/_ContextualMenu.scss index 18873978d3b..a010f44764d 100644 --- a/res/css/structures/_ContextualMenu.scss +++ b/res/css/structures/_ContextualMenu.scss @@ -41,7 +41,7 @@ limitations under the License. } .mx_ContextualMenu_right { - right: 0; + right: 16px; } .mx_ContextualMenu.mx_ContextualMenu_withChevron_right { diff --git a/res/css/views/rooms/_MessageComposer.scss b/res/css/views/rooms/_MessageComposer.scss index cba0a1e70da..07ef526c24a 100644 --- a/res/css/views/rooms/_MessageComposer.scss +++ b/res/css/views/rooms/_MessageComposer.scss @@ -21,7 +21,7 @@ limitations under the License. border-top: 1px solid $primary-hairline-color; position: relative; padding-left: 42px; - padding-right: 6px; + padding-right: 16px; } .mx_MessageComposer_replaced_wrapper { From 310672e59ccc7ab5a40f998852742233ee8bba5e Mon Sep 17 00:00:00 2001 From: Andy Balaam Date: Tue, 1 Feb 2022 14:50:46 +0000 Subject: [PATCH 08/12] Reduce shadow on composer More menu --- res/css/views/rooms/_MessageComposer.scss | 2 ++ 1 file changed, 2 insertions(+) diff --git a/res/css/views/rooms/_MessageComposer.scss b/res/css/views/rooms/_MessageComposer.scss index 07ef526c24a..3b5ec8365b2 100644 --- a/res/css/views/rooms/_MessageComposer.scss +++ b/res/css/views/rooms/_MessageComposer.scss @@ -412,4 +412,6 @@ limitations under the License. min-width: 150px; width: max-content; padding: 5px 10px 5px 0; + box-shadow: 0px 2px 9px rgba(0, 0, 0, 0.25); + border-radius: 8px; } From 6e78236e1001a792e86a8d779e9a208cacc77be3 Mon Sep 17 00:00:00 2001 From: Andy Balaam Date: Tue, 1 Feb 2022 14:53:23 +0000 Subject: [PATCH 09/12] From review: remove else clause --- src/components/views/rooms/CollapsibleButton.tsx | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/components/views/rooms/CollapsibleButton.tsx b/src/components/views/rooms/CollapsibleButton.tsx index c08073d8e25..b9e9f083d0a 100644 --- a/src/components/views/rooms/CollapsibleButton.tsx +++ b/src/components/views/rooms/CollapsibleButton.tsx @@ -35,15 +35,15 @@ export const CollapsibleButton = ({ title, children, className, ...props }: ICol { title } { children } ; - } else { - return - { children } - ; } + + return + { children } + ; }; export default CollapsibleButton; From f7b063c375dd11426aa3f0372172ec6ff9da35a5 Mon Sep 17 00:00:00 2001 From: Andy Balaam Date: Tue, 1 Feb 2022 15:00:46 +0000 Subject: [PATCH 10/12] From review: take input out of button --- .../views/rooms/MessageComposerButtons.tsx | 21 +++++++++---------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/src/components/views/rooms/MessageComposerButtons.tsx b/src/components/views/rooms/MessageComposerButtons.tsx index 877c70cca54..b6dcad81e69 100644 --- a/src/components/views/rooms/MessageComposerButtons.tsx +++ b/src/components/views/rooms/MessageComposerButtons.tsx @@ -243,21 +243,20 @@ class UploadButton extends React.Component { render() { const uploadInputStyle = { display: 'none' }; - return ( + return <> - - - ); + /> + + ; } } From e8a15abe6beb23983b65208217a9c754d0b93f8a Mon Sep 17 00:00:00 2001 From: Andy Balaam Date: Tue, 1 Feb 2022 15:30:16 +0000 Subject: [PATCH 11/12] Update test snapshots --- .../elements/__snapshots__/PollCreateDialog-test.tsx.snap | 4 ---- 1 file changed, 4 deletions(-) diff --git a/test/components/views/elements/__snapshots__/PollCreateDialog-test.tsx.snap b/test/components/views/elements/__snapshots__/PollCreateDialog-test.tsx.snap index 141a0ae258d..b089c685d66 100644 --- a/test/components/views/elements/__snapshots__/PollCreateDialog-test.tsx.snap +++ b/test/components/views/elements/__snapshots__/PollCreateDialog-test.tsx.snap @@ -36,7 +36,6 @@ exports[`PollCreateDialog renders a blank poll 1`] = ` "filteredTimelineSets": Object {}, "getTypeWarning": false, "getVersionWarning": false, - "lastThread": undefined, "membersPromise": Promise {}, "myUserId": "@name:example.com", "name": "roomid", @@ -257,7 +256,6 @@ exports[`PollCreateDialog renders a blank poll 1`] = ` "filteredTimelineSets": Object {}, "getTypeWarning": false, "getVersionWarning": false, - "lastThread": undefined, "membersPromise": Promise {}, "myUserId": "@name:example.com", "name": "roomid", @@ -1159,7 +1157,6 @@ exports[`PollCreateDialog renders a question and some options 1`] = ` "filteredTimelineSets": Object {}, "getTypeWarning": false, "getVersionWarning": false, - "lastThread": undefined, "membersPromise": Promise {}, "myUserId": "@name:example.com", "name": "roomid", @@ -1380,7 +1377,6 @@ exports[`PollCreateDialog renders a question and some options 1`] = ` "filteredTimelineSets": Object {}, "getTypeWarning": false, "getVersionWarning": false, - "lastThread": undefined, "membersPromise": Promise {}, "myUserId": "@name:example.com", "name": "roomid", From 522c181e82c14604dac37e7a360469ad4020e661 Mon Sep 17 00:00:00 2001 From: Andy Balaam Date: Wed, 2 Feb 2022 09:18:03 +0000 Subject: [PATCH 12/12] Update snapshots --- .../elements/__snapshots__/PollCreateDialog-test.tsx.snap | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/components/views/elements/__snapshots__/PollCreateDialog-test.tsx.snap b/test/components/views/elements/__snapshots__/PollCreateDialog-test.tsx.snap index b089c685d66..141a0ae258d 100644 --- a/test/components/views/elements/__snapshots__/PollCreateDialog-test.tsx.snap +++ b/test/components/views/elements/__snapshots__/PollCreateDialog-test.tsx.snap @@ -36,6 +36,7 @@ exports[`PollCreateDialog renders a blank poll 1`] = ` "filteredTimelineSets": Object {}, "getTypeWarning": false, "getVersionWarning": false, + "lastThread": undefined, "membersPromise": Promise {}, "myUserId": "@name:example.com", "name": "roomid", @@ -256,6 +257,7 @@ exports[`PollCreateDialog renders a blank poll 1`] = ` "filteredTimelineSets": Object {}, "getTypeWarning": false, "getVersionWarning": false, + "lastThread": undefined, "membersPromise": Promise {}, "myUserId": "@name:example.com", "name": "roomid", @@ -1157,6 +1159,7 @@ exports[`PollCreateDialog renders a question and some options 1`] = ` "filteredTimelineSets": Object {}, "getTypeWarning": false, "getVersionWarning": false, + "lastThread": undefined, "membersPromise": Promise {}, "myUserId": "@name:example.com", "name": "roomid", @@ -1377,6 +1380,7 @@ exports[`PollCreateDialog renders a question and some options 1`] = ` "filteredTimelineSets": Object {}, "getTypeWarning": false, "getVersionWarning": false, + "lastThread": undefined, "membersPromise": Promise {}, "myUserId": "@name:example.com", "name": "roomid",