diff --git a/test/end-to-end-tests/src/session.ts b/test/end-to-end-tests/src/session.ts index 84f22c4b0cb..26590594eef 100644 --- a/test/end-to-end-tests/src/session.ts +++ b/test/end-to-end-tests/src/session.ts @@ -40,7 +40,7 @@ export class ElementSession { "requestfinished", async (req: puppeteer.HTTPRequest) => { const type = req.resourceType(); const response = await req.response(); - return `${type} ${response.status()} ${req.method()} ${req.url()} \n`; + return `${type} ${response?.status() ?? ''} ${req.method()} ${req.url()} \n`; }); this.log = new Logger(this.username); } diff --git a/test/end-to-end-tests/src/util.ts b/test/end-to-end-tests/src/util.ts index 1c4e78933aa..3b31de2d1e2 100644 --- a/test/end-to-end-tests/src/util.ts +++ b/test/end-to-end-tests/src/util.ts @@ -84,7 +84,8 @@ export async function serializeLog(msg: ConsoleMessage): Promise { // Note: we have to run the checks against the object in the page context, so call // evaluate instead of just doing it ourselves. const stringyArg: string = await arg.evaluate((argInContext: any) => { - if (argInContext.stack || (argInContext instanceof Error)) { + // sometimes the argument will be `null` or similar - treat it safely. + if (argInContext?.stack || (argInContext instanceof Error)) { // probably an error - toString it and append any properties which might not be // caught. For example, on HTTP errors the JSON stringification will capture the // status code.