Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/search spec says the only possible JSON body parameter is search_categories, but the example also has order_by and groupings (SPEC-358) #644

Closed
matrixbot opened this issue Feb 24, 2016 · 4 comments
Closed

/search spec says the only possible JSON body parameter is search_categories, but the example also has order_by and groupings (SPEC-358) #644

matrixbot opened this issue Feb 24, 2016 · 4 comments
Labels
spec-bug Something which is in the spec, but is wrong

Comments

@matrixbot
Copy link
Member

Submitted by @​matthew:matrix.org

(Imported from https://matrix.org/jira/browse/SPEC-358)
@matrixbot matrixbot changed the title /search spec says the only possible JSON body parameter is search_categories, but the example also has order_by and groupings /search spec says the only possible JSON body parameter is search_categories, but the example also has order_by and groupings (SPEC-358) Oct 31, 2016
@matrixbot matrixbot added spec-bug Something which is in the spec, but is wrong spec-omission implemented but not currently specified labels Nov 7, 2016
@jimmycuadra
Copy link
Contributor

I just came to this while working on ruma-client-api. Which one is correct, the definition or the example?

/cc @ara4n

@jimmycuadra
Copy link
Contributor

jimmycuadra commented Dec 31, 2016 •
edited
Loading

Furthermore, does the "Room Events" object in the request (the search criteria) also have order_by and groupings, or were those two fields supposed to be only top-level as shown in the examples?

@jimmycuadra jimmycuadra mentioned this issue Aug 16, 2017
Open
@richvdh richvdh removed the spec-omission implemented but not currently specified label Oct 11, 2017
@richvdh richvdh mentioned this issue Jun 4, 2018
Closed
@richvdh
Copy link
Member

richvdh commented Jun 4, 2018

see also #1276

@t3chguy t3chguy mentioned this issue Jun 5, 2018
Merged
@richvdh
Copy link
Member

richvdh commented Jun 5, 2018

@jimmycuadra let us know if #1278 didn't fully address this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec-bug Something which is in the spec, but is wrong
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jimmycuadra @richvdh @matrixbot